Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule in PreAndPostProcessingScripts following support for reading namelist and streams files #28

Closed
4 tasks done
pwolfram opened this issue Oct 7, 2016 · 9 comments
Assignees

Comments

@pwolfram
Copy link
Contributor

pwolfram commented Oct 7, 2016

Following completion of recent improvements to generalize usage of MPAS-Analysis we will need to update the submodule for inclusion in ACME (https://github.com/ACME-Climate/PreAndPostProcessingScripts). The goal of this issue is to document PRs that we want to make sure are included as part of this update process.

A partial list of improvements (issues / PRs) to be included:

@pwolfram
Copy link
Contributor Author

@milenaveneziani, do you think we are missing anything on the above list?

@xylar xylar changed the title Update submodule in PreAndPostProcessingScripts Update submodule in PreAndPostProcessingScripts following support for reading namelist and streams files Nov 4, 2016
@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 5, 2016

Thanks for the updates @milenaveneziani and @xylar in the above list.

@pwolfram
Copy link
Contributor Author

@milenaveneziani and @xylar, following merging of #55, my understanding is that we can update PreAndPostProcessingScripts and close this issue, correct?

@xylar
Copy link
Collaborator

xylar commented Dec 12, 2016

That's my understanding as well.

@pwolfram
Copy link
Contributor Author

Note, I believe that we should be able to close this issue following resolution of https://github.com/ACME-Climate/PreAndPostProcessingScripts/pull/24.

@xylar
Copy link
Collaborator

xylar commented Jan 26, 2017

Until that PR is actually merged, I think this should stay open.

@pwolfram
Copy link
Contributor Author

Agreed, issues should only be closed after rectifying PRs are merged.

@milenaveneziani
Copy link
Collaborator

yes, we should be close to fulfill ACME-Climate/PreAndPostProcessingScripts#24.

@milenaveneziani
Copy link
Collaborator

ACME-Climate/PreAndPostProcessingScripts#24 was fulfilled, so closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants