From daf172a62f8d199e85b36e4599715a6bddf2ff46 Mon Sep 17 00:00:00 2001
From: Feliciaan De Palmenaer <feliciaan@de-palmenaer.eu>
Date: Fri, 1 Dec 2023 18:50:53 +0100
Subject: [PATCH] Changed fintro specific bank integration to work with BNP and
 Hello Bank (#285)

---
 src/app-gocardless/bank-factory.js                        | 4 ++--
 .../banks/{fintro-be-gebabebb.js => bnp-be-gebabebb.js}   | 8 ++++++--
 upcoming-release-notes/285.md                             | 6 ++++++
 3 files changed, 14 insertions(+), 4 deletions(-)
 rename src/app-gocardless/banks/{fintro-be-gebabebb.js => bnp-be-gebabebb.js} (94%)
 create mode 100644 upcoming-release-notes/285.md

diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.js
index cd0be562..b8ef1933 100644
--- a/src/app-gocardless/bank-factory.js
+++ b/src/app-gocardless/bank-factory.js
@@ -4,7 +4,7 @@ import IntegrationBank from './banks/integration-bank.js';
 import MbankRetailBrexplpw from './banks/mbank-retail-brexplpw.js';
 import NorwegianXxNorwnok1 from './banks/norwegian-xx-norwnok1.js';
 import SandboxfinanceSfin0000 from './banks/sandboxfinance-sfin0000.js';
-import FintroBeGebabebb from './banks/fintro-be-gebabebb.js';
+import BnpBeGebabebb from './banks/bnp-be-gebabebb.js';
 import DanskeBankDabNO22 from './banks/danskebank-dabno22.js';
 import SparNordSpNoDK22 from './banks/sparnord-spnodk22.js';
 import Belfius from './banks/belfius_gkccbebb.js';
@@ -15,7 +15,7 @@ const banks = [
   MbankRetailBrexplpw,
   SandboxfinanceSfin0000,
   NorwegianXxNorwnok1,
-  FintroBeGebabebb,
+  BnpBeGebabebb,
   DanskeBankDabNO22,
   SparNordSpNoDK22,
   Belfius,
diff --git a/src/app-gocardless/banks/fintro-be-gebabebb.js b/src/app-gocardless/banks/bnp-be-gebabebb.js
similarity index 94%
rename from src/app-gocardless/banks/fintro-be-gebabebb.js
rename to src/app-gocardless/banks/bnp-be-gebabebb.js
index 8a568799..e454d2b7 100644
--- a/src/app-gocardless/banks/fintro-be-gebabebb.js
+++ b/src/app-gocardless/banks/bnp-be-gebabebb.js
@@ -16,7 +16,11 @@ const SORTED_BALANCE_TYPE_LIST = [
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {
-  institutionIds: ['FINTRO_BE_GEBABEBB'],
+  institutionIds: [
+    'FINTRO_BE_GEBABEBB',
+    'HELLO_BE_GEBABEBB',
+    'BNP_BE_GEBABEBB',
+  ],
 
   normalizeAccount(account) {
     return {
@@ -32,7 +36,7 @@ export default {
     };
   },
 
-  /** FINTRO_BE_GEBABEBB provides a lot of useful information via the 'additionalField'
+  /** BNP_BE_GEBABEBB provides a lot of useful information via the 'additionalField'
    *  There does not seem to be a specification of this field, but the following information is contained in its subfields:
    *  - for pending transactions: the 'atmPosName'
    *  - for booked transactions: the 'narrative'.
diff --git a/upcoming-release-notes/285.md b/upcoming-release-notes/285.md
new file mode 100644
index 00000000..5aef22be
--- /dev/null
+++ b/upcoming-release-notes/285.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [feliciaan]
+---
+
+Fix: add fixes for BNP Paribas Fortis and Hello Bank
\ No newline at end of file