Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Fitting Runs Not Perfectly Reproducible #9

Open
SimWdm opened this issue Sep 7, 2024 · 3 comments
Open

Model Fitting Runs Not Perfectly Reproducible #9

SimWdm opened this issue Sep 7, 2024 · 3 comments
Assignees

Comments

@SimWdm
Copy link
Member

SimWdm commented Sep 7, 2024

As pointed out by by @rdrighetto in #8 (comment), model fitting on the same data with the same random seed yields fitting and validation curves that are very similar but not identical as expected.

I found that the random rotations of the subtomos during model fitting are not seeded which is a likely explanation. I will implement proper seeding in a new branch and see if this fixes the issue.

@SimWdm SimWdm self-assigned this Sep 7, 2024
@rdrighetto
Copy link

Hi again,

As stated in my last reply in #8, I was running comparisons between the current stable release based on MRC subtomograms and the torch_subtomos branch.
I ran the test 4 times in total, 2x with MRC and 2x with torch subtomos, all else being equal. Of the three runs that went to completion, all results look similar and have similar training and validation curves, but are not identical, including both runs of the torch_subtomos branch. This might be explained by the random rotations not being seeded, as you found out, @SimWdm.

Please let me know if I can help with more tests or if you need more details!

@SimWdm
Copy link
Member Author

SimWdm commented Sep 18, 2024

Hi Ricardo, just a quick heads up: Unfortunately I have not yet had the time to look into this as I am currently pushing towards a paper deadline. Please be assured that I have not forgotten about this issue!

@rdrighetto
Copy link

rdrighetto commented Sep 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants