Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Improve code structure in navbar #45

Open
GunaShekar02 opened this issue Feb 2, 2021 · 3 comments
Open

Improve code structure in navbar #45

GunaShekar02 opened this issue Feb 2, 2021 · 3 comments
Assignees
@m2chan

Comments

@GunaShekar02
Copy link
Member

The nav-bar class has a sub-class nav-logo, which has both the logo and the link to CV. I guess they should be separated and the nav-logo class should only have the logo under it and the CV should be separated.
@GunaShekar02 GunaShekar02 mentioned this issue Feb 2, 2021
Closed
@m2chan
Copy link
Member

m2chan commented Feb 2, 2021

My team can take this

@Korusuke
Copy link
Member

Korusuke commented Feb 2, 2021

Great @m2chan! Let me know if you need a hand!

@steven-tey
Copy link

Update from @m2chan's team: we made a PR!

https://github.com/MLH-Fellowship/portfolio-template/pull/65

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@m2chan m2chan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Korusuke @steven-tey @GunaShekar02 @m2chan