Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Add Github / Netlify Actions to deploy PRs #40

Open
Korusuke opened this issue Feb 2, 2021 · 2 comments
Open

Add Github / Netlify Actions to deploy PRs #40

Korusuke opened this issue Feb 2, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Korusuke
Copy link
Member

Korusuke commented Feb 2, 2021

It would be great to deploy PRs so that it's easy to review / test them, this deployments links can be commented in the PR itself.

https://docs.netlify.com/site-deploys/notifications/#github-pull-request-comments

@Korusuke Korusuke added the enhancement New feature or request label Feb 2, 2021
@wrussell1999
Copy link
Member

I actually added Netlify this morning! There’s one issue though: it breaks because of the github pages site being hosted on /portfolio-site

@jkmartindale
Copy link
Member

jkmartindale commented Feb 5, 2021

There’s one issue though: it breaks because of the github pages site being hosted on /portfolio-site

If it helps, I got a working deployment at https://agitated-davinci-5178e1.netlify.app/ with a corresponding netlify.toml. My build config does 3 things:

  • Set _site as the publish directory so Netlify doesn't serve raw templates
  • Install nokogiri before everything else, because for some reason that fixes issues I ran across when I added github-pages (to keep environments consistent)
  • Hacky build-time config file generation that overrides the URL structure to match deployment URL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants