Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Add GitHub Action to make sure the PRs build successfully #17

Open
wrussell1999 opened this issue Jan 22, 2021 · 4 comments · Fixed by #22
Open

Add GitHub Action to make sure the PRs build successfully #17

wrussell1999 opened this issue Jan 22, 2021 · 4 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request

Comments

@wrussell1999
Copy link
Member

Add GitHub Action to make sure jekyll build builds successfully.

Bonus:

  • Checks that the template doesn't contain their configuration
@wrussell1999 wrussell1999 added the enhancement New feature or request label Jan 22, 2021
@felixfaisal
Copy link
Member

Hey @wrussell1999 when you say doesn't contain their configuration, you mean that the original configuration should not be tampered with?

@wrussell1999
Copy link
Member Author

wrussell1999 commented Feb 1, 2021

Hey @felixfaisal!

Basically just check that their pull request doesn't contain anything that's unique to their template like their experience, or photo etc so the template remains the same. If it detects these things, it fails the test.

These are (but not limited to):

  • Name
  • Photo
  • Experience
  • Education
  • Projects
  • Project blogs

Feel free to let me know if you think of anything else

@felixfaisal
Copy link
Member

felixfaisal commented Feb 1, 2021

@wrussell1999 I will work on this issue

@wrussell1999
Copy link
Member Author

Excellent! Let me know if you need a hand :D @felixfaisal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants