Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Global variables for customising #10

Open
wrussell1999 opened this issue Jan 22, 2021 · 6 comments
Open

Global variables for customising #10

wrussell1999 opened this issue Jan 22, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@wrussell1999
Copy link
Member

At the moment, you have to do a lot of digging to customise the website to add your own flare to it.

Suggestion

Add a global CSS variable file where you can set the following:

  • Hero background color
  • Font family
  • Font size
  • Font color
  • Number of cards displayed on a page

Open to other suggestions too.

@wrussell1999 wrussell1999 added the enhancement New feature or request label Jan 22, 2021
@anjalisoni3655
Copy link
Member

@wrussell1999 We can add a CSS file for that, which will be used in all the pages, the number of cards need to be dynamic right?

@wrussell1999
Copy link
Member Author

wrussell1999 commented Feb 2, 2021

@anjalisoni3655 what I mean by number of cards is I'm using a CSS grid to say how many cards across for different screen sizes. Maybe this could be changed if someone wanted less cards.

Using 1 large CSS file means some stuff will be loaded on every page that isn't needed. Not ideal. Some stuff will be the same for every page.

@anjalisoni3655
Copy link
Member

@wrussell1999 yah correct, can you explain more how you want the structure of the styling files be

@wrussell1999
Copy link
Member Author

@anjalisoni3655 here's an example from another Jekyll template https://github.com/mmistakes/minimal-mistakes/blob/master/_sass/minimal-mistakes/_variables.scss

@LucasLobo
Copy link
Contributor

Is someone doing this? We could take it. @anjalisoni3655 @wrussell1999

@anjalisoni3655
Copy link
Member

Is someone doing this? We could take it. @anjalisoni3655 @wrussell1999

You can do that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants