Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Save/Load using pickle #120

Open
csala opened this issue Jan 28, 2020 · 1 comment
Open

Implement Save/Load using pickle #120

csala opened this issue Jan 28, 2020 · 1 comment
Labels
good first issue Easy task ideal for new contributors new feature

Comments

@csala
Copy link
Contributor

csala commented Jan 28, 2020

Current save/load methods focus on dumping and loading the pipeline definition in its JSON form, but provide no means to save a fitted pipeline and load it later to make predictions, being the usage of pickle outside of the pipeline the only way to go.

Let's re-implement the save/load methods to save the whole pipeline instance, and move the current save functionality to a to_json method.

Note that from_json is not needed anymore because the pipeline annotation can already be passed as a JSON path in the pipeline __init__ method.

@csala csala added new feature good first issue Easy task ideal for new contributors labels Jan 28, 2020
@WALEX2000
Copy link

Hey, it's been quite some time since I've seen any updates, and I was currently looking into this issue precisely. Is this project dead in the water?

gsheni pushed a commit that referenced this issue Aug 29, 2022
…umentation

Issue 7 add contributing documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy task ideal for new contributors new feature
Projects
None yet
Development

No branches or pull requests

2 participants