Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MLBlock -> MLPipelineStep #103

Open
micahjsmith opened this issue Aug 27, 2019 · 1 comment
Open

Rename MLBlock -> MLPipelineStep #103

micahjsmith opened this issue Aug 27, 2019 · 1 comment
Labels
approved The issue is approved and work can be started backwards incompatible internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance
Milestone

Comments

@micahjsmith
Copy link

That's it :)

@csala
Copy link
Contributor

csala commented Aug 29, 2019

Hi @micahjsmith I agree that the "block" name usage can be a bit confusing within the scope of a pipeline.
However, an MLBlock is thought as an independent block of code that can also be executed on its own, outside of the pipeline scope.

The whole rationale of the project naming is:

  • An MLBlock is just a wrapper around a third party block of code, which provides it a uniform interface suitable for Machine Learning contexts. This is the core concept of the library.
  • The MLBlocks library is called like that because its core concept is being able to create precisely that: instances of the MLBlock class.
  • Eventually, we provide the MLPipeline, which allows to easily combine multiple MLBlock instances in the form of a pipeline. This, of course, ends up being a very important concept in the project, but it still revolves around the MLBlock concept.

So, here is my proposal: Let's keep the MLBlock class name, but rename the block concept inside the pipeline to steps.

This way, the MLPipeline will be composed of multiple steps, which inherently have an execution order, and it just happens that each one of these steps is an instance of an MLBlock class.

Does this sound right?

@csala csala added the under discussion The issue is still being discussed label Aug 29, 2019
@csala csala added this to the 0.4.0 milestone Dec 5, 2019
@csala csala added approved The issue is approved and work can be started internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance backwards incompatible and removed under discussion The issue is still being discussed labels Dec 5, 2019
@csala csala modified the milestones: 0.4.1, 0.5.0 Mar 8, 2021
@sarahmish sarahmish modified the milestones: 0.5.0, 0.5.1 Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The issue is approved and work can be started backwards incompatible internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance
Projects
None yet
Development

No branches or pull requests

3 participants