Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?] Lack of the threshold judgement for the number of inliers during the monocular RANSAC? #5

Open
RonghaiHe opened this issue Jan 13, 2025 · 0 comments

Comments

@RonghaiHe
Copy link

I have noticed that the monocular RANSAC (geometricVerificationNister) in the loop_closure_detector.cpp just judges if the percentage of inliners > threshold (happens in this line),
while the stereo RANSAC (recoverPose) judges both the number of inliers and the percentage of them (happens in these lines).

Compared with the intra-loop closure detection part in the Kimera-VIO, the mono RANSAC also judges if the number of inliers satisfies the threshold (happens in these lines).

So is it a bug that the threshold judgement of the number of inliers is lack during monocular RANSAC? Thank you for your attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant