Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitemap.xml contains only broken links #172

Closed
orbeckst opened this issue Oct 10, 2021 · 6 comments · Fixed by #173 or #279
Closed

sitemap.xml contains only broken links #172

orbeckst opened this issue Oct 10, 2021 · 6 comments · Fixed by #173 or #279
Labels

Comments

@orbeckst
Copy link
Member

Describe the bug
The https://userguide.mdanalysis.org/2.0.0/sitemap.xml only contains broken links because a slash is missing after the hostname, for instance

<?xml version='1.0' encoding='utf-8'?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url><loc>https://userguide.mdanalysis.orgadvanced_topology.html</loc></url>
<url><loc>https://userguide.mdanalysis.orgatomgroup.html</loc></url>
<url><loc>https://userguide.mdanalysis.orgcontributing.html</loc></url>
...

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://userguide.mdanalysis.org/2.0.0/sitemap.xml
  2. look at file

Expected behavior
Links should link to actual pages

Actual behavior
Links are incomplete and thus broken.

Therefore, pages are not indexed for search.

Additional context
See also MDAnalysis/MDAnalysis.github.io#202

@orbeckst orbeckst mentioned this issue Oct 10, 2021
orbeckst added a commit that referenced this issue Oct 16, 2021
@orbeckst
Copy link
Member Author

I just check https://userguide.mdanalysis.org/stable/sitemap.xml and https://userguide.mdanalysis.org/2.0.0/sitemap.xml and they are still missing forward slashes after the hostname. Can you please check?

@orbeckst orbeckst reopened this Oct 16, 2021
@orbeckst
Copy link
Member Author

Did you manually fix the "stable" sitemap?

@jandom
Copy link
Contributor

jandom commented Jul 26, 2023

Eh, this still looks busted to me https://userguide.mdanalysis.org/stable/sitemap.xml

@jandom jandom reopened this Jul 26, 2023
@lilyminium
Copy link
Member

Ah, this should get manually fixed, yes. Any recent changes to the repo will only affect the development versions unless we re-trigger building of previous docs. The develop sitemap looks better: https://userguide.mdanalysis.org/dev/sitemap.xml

@jandom
Copy link
Contributor

jandom commented Jul 26, 2023

Ah, okay – nevermind then!

@jandom jandom closed this as completed Jul 26, 2023
@lilyminium
Copy link
Member

I updated gh-pages manually for old releases -- https://userguide.mdanalysis.org/stable/sitemap.xml looks good now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants