Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Cards has bad name in encapsulation exercise #73

Open
mrmanc opened this issue Mar 15, 2021 · 0 comments
Open

JS Cards has bad name in encapsulation exercise #73

mrmanc opened this issue Mar 15, 2021 · 0 comments
Labels
encapsulation javascript Changes which involve JS

Comments

@mrmanc
Copy link
Member

mrmanc commented Mar 15, 2021

Not relevant to the exercise but there is the line: let x = new Array(a);

Might be worth using a different name to avoid this distracting from the critique of the structure.
@mrmanc mrmanc changed the title JS Cards has bad name JS Cards has bad name in encapsulation exercise Mar 17, 2021
@mrmanc mrmanc added encapsulation javascript Changes which involve JS labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encapsulation javascript Changes which involve JS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrmanc