You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disclaimer: this does not affect the team grading but it's something that I usually do both in 310 or 410 as this kind of feedback may bring new ideas to the table.
I took a quick look at the project and the parsing and evaluating follows the code presented in the lectures, but you could further refine the evaluating functions.
Could use a factory to distinguish the execution flow from the cases where isVector is true and the cases where it is not. Another interesting thing that could be used more often is String templating. Compilation wise, Java optimizes String concatenation and there is no difference IIRC. But string templating will help coders seeing the whole block and where the variables will fit. As an example:
Please remember that you all did a great job, take this comments lightly. I'll be glad to discuss more about refactoring and their trade-offs if you guys are interested.
Looking forward to seeing the video during the Film Fest.
The text was updated successfully, but these errors were encountered:
Disclaimer: this does not affect the team grading but it's something that I usually do both in 310 or 410 as this kind of feedback may bring new ideas to the table.
I took a quick look at the project and the parsing and evaluating follows the code presented in the lectures, but you could further refine the evaluating functions.
As some examples:
Could use a factory to distinguish the execution flow from the cases where isVector is true and the cases where it is not. Another interesting thing that could be used more often is String templating. Compilation wise, Java optimizes String concatenation and there is no difference IIRC. But string templating will help coders seeing the whole block and where the variables will fit. As an example:
Could be turned to:
It helps both during readability as well as as in debugging. It's easier to debug and locate errors that may happen during development.
Could also use a map adding the string of the if comparison as a
key
and the function as avalue
.All these lines would be replaced by something like:
Please remember that you all did a great job, take this comments lightly. I'll be glad to discuss more about refactoring and their trade-offs if you guys are interested.
Looking forward to seeing the video during the Film Fest.
The text was updated successfully, but these errors were encountered: