Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a new tag (e.g. 4.03) #325

Open
jonesmz opened this issue Nov 20, 2023 · 5 comments
Open

Please make a new tag (e.g. 4.03) #325

jonesmz opened this issue Nov 20, 2023 · 5 comments

Comments

@jonesmz
Copy link
Contributor

jonesmz commented Nov 20, 2023

This commit removed the file dCore/ndSaveLoadSytem.h : 4e567b6

in git tag https://github.com/MADEAPPS/newton-dynamics/releases/tag/v4.02 for newton-dynamics/newton-4.00, this file has a syntax error.

Specifically:

template<class T>
class ndLoadSaveClass: public ndLoadSaveBase
{
  public:
  ndLoadSaveClass<T>(const char* const className)
  {
		RegisterLoaderClass(className, this);
	}

	virtual void* CreateClass(const ndLoadDescriptor& desc)
	{
		return new T(desc);
	}
};

the constructor on the 5th line of the class ndLoadSaveClass also has the extraneous <T>

This means that on many compilers, such as GCC or Clang, newton-4.00 cannot compile with tag 4.02

A new tag (e.g 4.03) would allow me to continue switching to newton 4.00.

@jonesmz
Copy link
Contributor Author

jonesmz commented Nov 20, 2023

Please also include these changes in the new tag:
#322
#324

Both of them are needed to be able to build on my system

@JulioJerez
Copy link
Contributor

I do not understand, I can buidl an run in linux fine. I also can build on VS selecting Clang compiler
I believe I merge: 322 and 324
please sync and tell me if I still need this.
also I will make a new tag over this long weekend, about next week.
I have to re enable few demos that are commented out.

@jonesmz
Copy link
Contributor Author

jonesmz commented Nov 21, 2023

My project only uses official releases (or git tags) of third party projects. Can't update to a specific commit.

@JulioJerez
Copy link
Contributor

ok, I will make teh Tag this weekend,
If I made now, them the user that use the engine will get it and will get many demo malfunctions, and I will get many PM
Juts wait until this Saturday, and I will make that stable Tag.

@jonesmz
Copy link
Contributor Author

jonesmz commented Nov 21, 2023

No need to rush, any time in the next couple of months is fine, but if you're in a good spot for it this weekend, that's great too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants