Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake target aliases #227

Open
jonesmz opened this issue Feb 27, 2021 · 2 comments
Open

Add cmake target aliases #227

jonesmz opened this issue Feb 27, 2021 · 2 comments

Comments

@jonesmz
Copy link
Contributor

jonesmz commented Feb 27, 2021

Currently in my project, I have to do:

target_link_libraries(myexe PRIVATE
    ${CMAKE_THREAD_LIBS_INIT}
    dNewton dScene dModel dVehicle
    )

I would much rather do this

target_link_libraries(myexe PRIVATE
    ${CMAKE_THREAD_LIBS_INIT}
    Newton::Newton Newton::Scene Newton::Model Newton::Vehicle
    )

Without the d prefix

@JulioJerez
Copy link
Contributor

I do not understand why is that problem, that's just the class name.
d or not d is just your preference, I can assure you ther will be someone who will like a different preference.

@jonesmz
Copy link
Contributor Author

jonesmz commented Mar 1, 2021

I think there is a miscommunication.

By using cmake aliases, it keeps the cmake scripts easier for projects to use.

It doesn't change the semantics of the projects being able to pick which variant of the thing they are pulling in.

But the cmake scripts for newton are very hard to understand, so I did not even realize there were different versions of these libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants