Fixed unnecessary temporary object using emplace

M-J-Hochreiter · M-J-Hochreiter · commit d93cec04ee86 · 2025-02-06T13:01:51.000+01:00
diff --git a/src/algorithms/StatePreparation.cpp b/src/algorithms/StatePreparation.cpp
@@ -230,8 +230,7 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,
         // qubit directly the controls are collected and then newly set
         qc::Controls newControls;
         for (const auto& control : op->getControls()) {
-          newControls.emplace(
-              qc::Control{control.qubit + static_cast<Qubit>(i)});
+          newControls.emplace(control.qubit + static_cast<Qubit>(i));
         }
         op->setControls(newControls);
       }
@@ -252,8 +251,7 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,
         // qubit directly the controls are collected and then newly set
         qc::Controls newControls;
         for (const auto& control : op->getControls()) {
-          newControls.emplace(
-              qc::Control{control.qubit + static_cast<Qubit>(i)});
+          newControls.emplace(control.qubit + static_cast<Qubit>(i));
         }
         op->setControls(newControls);
       }

Original file line number	Diff line number	Diff line change
`@@ -230,8 +230,7 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,`
`230`	`230`	`// qubit directly the controls are collected and then newly set`
`231`	`231`	`qc::Controls newControls;`
`232`	`232`	`for (const auto& control : op->getControls()) {`
`233`		`- newControls.emplace(`
`234`		`- qc::Control{control.qubit + static_cast<Qubit>(i)});`
	`233`	`+ newControls.emplace(control.qubit + static_cast<Qubit>(i));`
`235`	`234`	`}`
`236`	`235`	`op->setControls(newControls);`
`237`	`236`	`}`
`@@ -252,8 +251,7 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,`
`252`	`251`	`// qubit directly the controls are collected and then newly set`
`253`	`252`	`qc::Controls newControls;`
`254`	`253`	`for (const auto& control : op->getControls()) {`
`255`		`- newControls.emplace(`
`256`		`- qc::Control{control.qubit + static_cast<Qubit>(i)});`
	`254`	`+ newControls.emplace(control.qubit + static_cast<Qubit>(i));`
`257`	`255`	`}`
`258`	`256`	`op->setControls(newControls);`
`259`	`257`	`}`