Trying to directly access control qubit and increment it

M-J-Hochreiter · M-J-Hochreiter · commit 1436938bcb7e · 2025-02-03T12:53:22.000+01:00
diff --git a/src/algorithms/StatePreparation.cpp b/src/algorithms/StatePreparation.cpp
@@ -221,11 +221,8 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,
         for (auto& target : op->getTargets()) {
           target += static_cast<unsigned int>(i);
         }
-        for (auto control : op->getControls()) {
-          // there were some errors when accessing the qubit directly and
-          // adding to it
-          op->setControls(
-              Controls{Control{control.qubit + static_cast<unsigned int>(i)}});
+        for (auto& control: op->getControls()) {
+          control.qubit += static_cast<Qubit>(i);
         }
       }
       disentangler.emplace_back<Operation>(rzMultiplexer.asOperation());
@@ -242,12 +239,9 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,
         for (auto& target : op->getTargets()) {
           target += static_cast<unsigned int>(i);
         }
-        for (auto control : op->getControls()) {
-          // there were some errors when accessing the qubit directly and
-          // adding to it
-          op->setControls(
-              Controls{Control{control.qubit + static_cast<unsigned int>(i)}});
-        }
+      for (auto& control: op->getControls()) {
+        control.qubit += static_cast<Qubit>(i);
+      }
       }
       disentangler.emplace_back<Operation>(ryMultiplexer.asOperation());
     }

Original file line number	Diff line number	Diff line change
`@@ -221,11 +221,8 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,`
`221`	`221`	`for (auto& target : op->getTargets()) {`
`222`	`222`	`target += static_cast<unsigned int>(i);`
`223`	`223`	`}`
`224`		`- for (auto control : op->getControls()) {`
`225`		`- // there were some errors when accessing the qubit directly and`
`226`		`- // adding to it`
`227`		`- op->setControls(`
`228`		`- Controls{Control{control.qubit + static_cast<unsigned int>(i)}});`
	`224`	`+ for (auto& control: op->getControls()) {`
	`225`	`+ control.qubit += static_cast<Qubit>(i);`
`229`	`226`	`}`
`230`	`227`	`}`
`231`	`228`	`disentangler.emplace_back<Operation>(rzMultiplexer.asOperation());`
`@@ -242,12 +239,9 @@ gatesToUncompute(std::vector<std::complex<double>>& amplitudes,`
`242`	`239`	`for (auto& target : op->getTargets()) {`
`243`	`240`	`target += static_cast<unsigned int>(i);`
`244`	`241`	`}`
`245`		`- for (auto control : op->getControls()) {`
`246`		`- // there were some errors when accessing the qubit directly and`
`247`		`- // adding to it`
`248`		`- op->setControls(`
`249`		`- Controls{Control{control.qubit + static_cast<unsigned int>(i)}});`
`250`		`- }`
	`242`	`+ for (auto& control: op->getControls()) {`
	`243`	`+ control.qubit += static_cast<Qubit>(i);`
	`244`	`+ }`
`251`	`245`	`}`
`252`	`246`	`disentangler.emplace_back<Operation>(ryMultiplexer.asOperation());`
`253`	`247`	`}`