Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyWebHistory | browserhistory.py and main.py #2

Open
codylellis opened this issue Apr 22, 2024 · 1 comment
Open

MyWebHistory | browserhistory.py and main.py #2

codylellis opened this issue Apr 22, 2024 · 1 comment

Comments

@codylellis
Copy link

browserhistory.py

Line 148, creating a backup of history file
I would recommend removing the if statement. I didn't completely debug it, but I can never get new history out of the plugin unless this line is removed.

main.py

Line 35: if qs[0] == 'vsc':

I would remove this because it generates a error in the error.log for index out of range, and don't get exact line error from logging module.
would add Log.error(traceback.format_exc())
under line 69

say something like the below to evaluate first

if 'vsc' in qs:

@Lyndon1994
Copy link
Owner

Thanks for your using and response, please feel free to commit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants