Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relic probability density seems incorrect #44

Open
eugenelourie opened this issue Dec 22, 2024 · 0 comments
Open

Relic probability density seems incorrect #44

eugenelourie opened this issue Dec 22, 2024 · 0 comments

Comments

@eugenelourie
Copy link

Hello! I might be mistaking, but these lines look strange:
https://github.com/Lux-AI-Challenge/Lux-Design-S3/blob/71236024b06fb65118dc814b483339e8c7ebc11f/src/luxai_s3/state.py#L279C9-L292C10

Comment in the line 279 states that the probability density is 25%, but after that the randint function is used:
relic_node_configs = ( jax.random.randint(... maxval=10, ).astype(jnp.float32) >= 7.5 )

Shouldn't it be something like:
relic_node_configs = ( jax.random.randint(... maxval=100, ).astype(jnp.float32) >= 75 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant