Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: A quick and easy way to change the font colour and the background colour #518

Open
Inquisitor-Ignotorum opened this issue Nov 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Inquisitor-Ignotorum
Copy link

Configuration: Windows 10, Lute v. 3.6.0 installed via pip

Hello. I use Lute every day, and I do a lot of reading with it. To ensure that the reading experience always remains as exciting as possible, I like changing the font colour and the background colour often (for example, yesterday I used a navy background with a white font, and today I have a dark grey background with a light yellow font). I do that with the very useful CSS text box in the "Settings" screen, but, since I do that once a day, I started thinking that maybe there can be an easier way to do this. It would be handy if there could be a quick, easy, and constantly accessible way to change the font colour and the background colour. At the moment, it seems to me that an easy and fast way to implement this would be to include two HTML colour pickers in the hamburger menu of the reading screen, one colour picker for the font colour and one colour picker for the background colour. It seems that this would enhance the user experience because the user would then have easy access to two customisation tools which would have great impact on the reading experience. This feature could also appeal to people who have little or no knowledge of coding.

But what happens when the user closes Lute or clears the browser's cache? The font colour and background colour choices will most likely be reset, and some users may dislike having to pick their chosen colour again, every time they restart Lute or clear the browser's cache. It may be useful to save the user's font colour and background colour choices somewhere, perhaps using their hex codes, so that Lute can constantly retrieve them when necessary.

What do you think? I am saying all this as somebody who has a lot of contact with Lute, so I am trying to think of how the user experience could be improved for everybody.

Thank you very much for your hard work. I think that your software is very beneficial.

@jzohrab
Copy link
Collaborator

jzohrab commented Nov 18, 2024

Hi @Inquisitor-Ignotorum - thanks for the issue and details :-)

I agree that some users would probably prefer this way of setting colors. You could include font styles in that list of basic settings too. I'm not sure how these would interact with the themes -- perhaps they'd only override the themes if set.

When set, they'd be stored in user preferences.

I'm unlikely to work on this issue myself soon (too much other stuff to do!) but it's a decent idea and maybe someone will be able to take a look at it.

Work involved:

  • find a flask color picker extension (perhaps) e.g. https://github.com/mrf345/flask_colorpicker or figure out how to get a js extension for it
  • user settings to save the colors, checkmarks to override themes
  • render the css into the base template, after the themes loaded

@jzohrab jzohrab added the enhancement New feature or request label Nov 18, 2024
@jzohrab jzohrab added this to Lute-v3 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants