limel-dialog: if the button slot is empty when the component is created, it will never be shown, even if populated later

[adrianschmidt]

Found while helping @simonedeblasio debug, as described in this forum thread (internal link).

Current behavior

Steps to reproduce the behavior:

1. Create a limel-dialog where no element in the dialog has slot="button".
2. Give the page time to render, so the dialog is hydrated.
3. Update the dialog by adding an element that has slot="button" set.

Result: the element with slot="button" is not shown, because the dialog has no footer, and thus no slot to show it in.

Expected behavior

The element with slot="button" should be shown in the dialog's footer. This happens because of

lime-elements/src/components/dialog/dialog.tsx

Line 112 in b3d5d2f

this.showFooter = !!this.host.querySelector('[slot="button"]');

, which we added because Lime Field needed a full screen dialog with no footer, if I recall correctly. I'm guessing this behaviour is no longer needed, so we can probably remove this little quirk, but if we don't, we should document it!

Environment

• lime-elements version: v0.8.0 and later (yes, v0.8.0 sic, 😂) This was introduced in fix(dialog): query host element before renderFooter is called #1222
• Framework used: none (StencilJS)
• Logs: