feat: minimal basic ide #17

0x736d · 2022-10-04T17:53:42Z

Tries to fix #1

features

Basic IDE setup with formatting, diagnostics and code action support for few common languages.
Better UI/UX for vim.ui.select and vim.ui.input using dressing.nvim with telescope backend.
Refactoring support through code actions using refactoring.nvim
Code actions for for git operations at the current cursor position i.e. stage/preview/reset hunk etc..

languages support added

Language servers for only c/c++, rust and go is manually configured.

C/C++
Typescript/Javascript
python
go
rust
bash
html
css
json
yaml
toml
dockerfile

additional plugins added

- enable format on save - enable breadcrumbs

- kanagawa - catppuccin

manually configured servers - rust_analyzer - clangd - gopls

- vim-surround - dressing.nvim - nvim-ts-autotag

- mapping added for search and replace - mappings added for diagnostics using trouble.nvim - mappings for refactoring should only be executed in visual mode

…tions

- LunarVim already installs language servers automatically

- user can use lunarvim docs to setup their favorite colorscheme

- removes unnecessary config functions

kronikpillow · 2022-10-27T07:00:35Z

this is actually a very good setup ... it's even better then the default one that comes with lvim, i'd definitely approve this as a template ...

only thing i'd add is lvim as a global to lsp, as lvim is marked as a undefined global in this setup

0x736d · 2022-10-27T19:19:23Z

@kronikpillow should be fixed after the recent commit

LostNeophyte · 2022-12-05T14:14:21Z

hi, sorry for the silence, are you still willing to work on this?

0x736d · 2022-12-06T03:56:30Z

@LostNeophyte yes on my spare time... but I was waiting on a review of some sort so I know if something needs changing in the existing PR.

LostNeophyte · 2022-12-06T05:39:17Z

I'll review it today (it's 7 am here) 6 Dec 2022, 04:56 by ***@***.***:

…

@LostNeophyte <https://github.com/LostNeophyte>> yes on my spare time... but I was waiting on a review of some sort so I know if something needs changing in the existing PR. — Reply to this email directly, > view it on GitHub <#17 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/A2KZQTS2MIDAF5KMZRSPAY3WL22PRANCNFSM6AAAAAAQ4ZYU3M>> . You are receiving this because you were mentioned.> Message ID: > <LunarVim/starter> .> lvim/pull/17/c1338704953> @> github> .> com>

config.lua

README.md

guidelines.md

README.md

- remove `on_init`, `on_attach`, `capabilities` since `lvim.lsp.manager` already resolves default values for them - remove redundant builtin config value

0x736d · 2022-12-06T11:15:28Z

@LostNeophyte I have added the suggested changes, also let me know if you want to add/remove any plugin.

LostNeophyte

LGTM, Thanks :)

kylo252 · 2022-12-11T15:21:02Z

README.md

@@ -2,8 +2,77 @@



let's move this file into .github/README.md

kylo252 · 2022-12-11T15:23:00Z

CONTRIBUTING.md

@@ -0,0 +1,5 @@
+# Submission Guidelines


it should also be fine to move this into .github/CONTRIBUTING.md¹

Footnotes

https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors#about-contributing-guidelines ↩

kylo252 · 2022-12-11T15:24:05Z

README.md

+- [Keybinds](#additional-keybinds)
+</details>
+
+## Supported languages


Suggested change

## Supported languages

## Available configurations

kylo252 · 2022-12-11T15:24:21Z

README.md

+> formatting, diagnostics, completions should work out of the box for the languages
+> below with the `LunarVim` configuration in this branch
+
+- C/C++


we should probably link to the branch

kylo252 · 2022-12-11T15:25:37Z

README.md

+## Requirements
+
+Most of the language servers installation should happen automatically, but there
+is a few that are manually configured and may requires manual installation.
+
+Install them with the command below
+
+```
+:MasonInstall clangd rust_analyzer gopls
+```
+
+Binaries needed for diagnostics and formatting requires manual installation.
+You need to install them using the builtin `mason.nvim` or with your favorite package
+manager.
+
+use the command below to install them with mason
+
+```
+:MasonInstall eslint_d prettier yamllint taplo goimports golangci-lint shellcheck shfmt hadolint flake8 black
+```
+
+### Additional keybinds
+
+> **Note**
+> Leader is mapped to <kbd>Space</kbd>
+
+| Mode   | Key                                         | Action                                        |
+| ------ | ------------------------------------------- | --------------------------------------------- |
+| visual | <kbd>Leader</kbd>+<kbd>r</kbd>+<kbd>r</kbd> | Refactor selection                            |
+| normal | <kbd>Leader</kbd>+<kbd>P</kbd>              | Project menu                                  |
+| normal | <kbd>Leader</kbd>+<kbd>r</kbd>+<kbd>o</kbd> | Search and replace (open spectre panel)       |
+| normal | <kbd>Leader</kbd>+<kbd>r</kbd>+<kbd>f</kbd> | Search and replace (search current file)      |
+| normal | <kbd>Leader</kbd>+<kbd>r</kbd>+<kbd>c</kbd> | Search and replace (search word under cursor) |
+| normal | <kbd>Leader</kbd>+<kbd>t</kbd>+<kbd>w</kbc> | Workspace diagnostics                         |
+| normal | <kbd>Leader</kbd>+<kbd>t</kbd>+<kbd>d</kbc> | Document diagnostics                          |
+| normal | <kbd>Leader</kbd>+<kbd>t</kbd>+<kbd>t</kbc> | LSP Type definitions                          |
+| normal | <kbd>Leader</kbd>+<kbd>t</kbd>+<kbd>r</kbc> | LSP references                                |
+| normal | <kbd>Leader</kbd>+<kbd>t</kbd>+<kbd>q</kbc> | Quickfix                                      |


please link to the docs site instead to avoid information decay

kylo252 · 2022-12-11T15:27:17Z

config.lua

@@ -0,0 +1,251 @@
+lvim.format_on_save = true


we don't need this file as it overlaps with purpose with the branches and config.example.lua, it would also be yet another piece of documentation that require maintenance.

@kylo252 So no config.lua in master branch and have links in README.md for branches with their respective lang/ide configuration... 😕 ( I think the original idea was to have examples configuration for few common languages and plugins etc.. )

To clarify, I'm talking about linking to this file instead: https://github.com/LunarVim/LunarVim/blob/d3ade21d85084634517848a7fd3582bbf2d6c278/utils/installer/config.example.lua

We should ideally have a single "common" example config.lua, that's always kept up to date with any changes/recommendations. We can always update that file, if you have any concrete ideas, see LunarVim/LunarVim#3519.

Sorry for the late response... I've added all the changes to #56 since after removing config.lua from this PR it wouldn't be addressing #1 anymore.

0x736d · 2022-12-15T08:17:12Z

closing in favor of #56

0x736d added 20 commits October 4, 2022 19:49

feat: start with basic lvim options and builtin configs

d8605c9

- enable format on save - enable breadcrumbs

feat: auto install treesitter parsers & some lsp servers

89b660c

fix: disable virtual_text for diagnostics

897f444

feat(plugin): add additional colorscheme plugins

8cbd476

- kanagawa - catppuccin

feat: add manual configurations for language servers

be6abb9

manually configured servers - rust_analyzer - clangd - gopls

feat: setup formatting and linting for common langs

53b5b1e

feat: setup codeactions using null-ls

16ba032

feat(plugin): add some utility plugins

9ee21db

- vim-surround - dressing.nvim - nvim-ts-autotag

feat(plugin): add refactoring.nvim

76c6b58

feat(plugin): add nvim-spectre & trouble.nvim with default setup options

05f2779

feat(keybinds): add additional which-key mappings

3b706fe

- mapping added for search and replace - mappings added for diagnostics using trouble.nvim - mappings for refactoring should only be executed in visual mode

fix: enable autotag

24001e0

chore: add .stylua.toml

988b2d1

chore: update .gitignore

cf691a4

fix: remove keymap for loclist & use correct provider for type defini…

619a29d

…tions

chore: update readme

bf7173e

chore: move submission guidelines to guidelines.md

12b0669

chore: update readme

d2ac91b

fix: use vim.deepcopy before modifying client capabilities

fbe163f

fix: add missing callbacks and options to gopls setup

9ca5c5f

SingularisArt added the Hacktoberfest label Oct 4, 2022

0x736d and others added 6 commits October 7, 2022 00:28

fix: remove ensure_installed table

157fec7

- LunarVim already installs language servers automatically

fix: remove unnecessary lunarvim opts

ee4579a

fix: remove colorscheme plugins

2162810

- user can use lunarvim docs to setup their favorite colorscheme

fix: update plugin table

e0af1bd

- removes unnecessary config functions

fix: remove rustfmt from null-ls formatting sources

26b31c0

Add .stylua.toml from Lunarvim/lunarvim (LunarVim#38)

118deaa

fix: pass lvim to --globals for luacheck

d71e226

LostNeophyte requested changes Dec 6, 2022

View reviewed changes

0x736d added 3 commits December 6, 2022 16:06

chore: rename guidelines.md to CONTRIBUTING.md

10b34f2

chore: update README.md

363f883

fix: update config.lua

0789072

- remove `on_init`, `on_attach`, `capabilities` since `lvim.lsp.manager` already resolves default values for them - remove redundant builtin config value

LostNeophyte approved these changes Dec 6, 2022

View reviewed changes

LostNeophyte requested review from ChristianChiarulli and kylo252 December 6, 2022 12:06

kylo252 requested changes Dec 11, 2022

View reviewed changes

0x736d closed this Dec 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: minimal basic ide #17

feat: minimal basic ide #17

0x736d commented Oct 4, 2022 •

edited

Loading

kronikpillow commented Oct 27, 2022 •

edited

Loading

0x736d commented Oct 27, 2022

LostNeophyte commented Dec 5, 2022 •

edited

Loading

0x736d commented Dec 6, 2022

LostNeophyte commented Dec 6, 2022 via email

0x736d commented Dec 6, 2022

LostNeophyte left a comment

kylo252 Dec 11, 2022

kylo252 Dec 11, 2022

kylo252 Dec 11, 2022

kylo252 Dec 11, 2022

kylo252 Dec 11, 2022

kylo252 Dec 11, 2022

0x736d Dec 11, 2022

kylo252 Dec 12, 2022

0x736d Dec 15, 2022

0x736d commented Dec 15, 2022

feat: minimal basic ide #17

feat: minimal basic ide #17

Conversation

0x736d commented Oct 4, 2022 • edited Loading

features

languages support added

kronikpillow commented Oct 27, 2022 • edited Loading

0x736d commented Oct 27, 2022

LostNeophyte commented Dec 5, 2022 • edited Loading

0x736d commented Dec 6, 2022

LostNeophyte commented Dec 6, 2022 via email

0x736d commented Dec 6, 2022

LostNeophyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Footnotes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x736d commented Dec 15, 2022

0x736d commented Oct 4, 2022 •

edited

Loading

kronikpillow commented Oct 27, 2022 •

edited

Loading

LostNeophyte commented Dec 5, 2022 •

edited

Loading