Track external android format #1695
Conversation
|
CI gfxreconstruct build queued with queue ID 245923. |
ziga-lunarg
force-pushed
the
track-external-format
branch
from
f28e398
to
7971641
Compare
|
CI gfxreconstruct build queued with queue ID 245925. |
|
CI gfxreconstruct build # 4725 running. |
|
CI gfxreconstruct build # 4725 passed. |
The external format from android must be tracked, because in GetImageResourceSizesOptimal we create temporary images from the same format to calculate the resource size If format is VK_FORMAT_UNDEFINED and the external android format is not provided it will crash on android
ziga-lunarg
force-pushed
the
track-external-format
branch
from
7971641
to
56fada1
Compare
|
CI gfxreconstruct build queued with queue ID 246259. |
A minimal test program would have to create an AHardwareBuffer and then create an image with an external android format, and allocate device memory with the AHardwareBuffer and bind it to the image. And I think this only happens in a trimmed capture. This should reproduce it, but not 100% sure. |
|
CI gfxreconstruct build # 4729 running. |
|
CI gfxreconstruct build # 4729 passed. |
Do we have a capture we could put in CI that replicates this or could you quickly write a program to replicate this? |
I do have a capture, but I've realized this fix is not enough. There is another problem later in the capture, that I thought was unrelated, but it seems that it is. |
bradgrantham-lunarg
added
the
P1
|
Can this be merged or is it part of a later PR? |
I might close this and open a different PR, because this only fixes a small part of the issue. |
The external format from android must be tracked, because in GetImageResourceSizesOptimal we create temporary images from the same format to calculate the resource size
If format is VK_FORMAT_UNDEFINED and the external android format is not provided it will crash on android