Skip to content
This repository has been archived by the owner on Jul 29, 2021. It is now read-only.

Hologram's call to UpdateDescriptorSets can specify a range that exceeds driver limits #178

Open
TonyBarbour opened this issue Aug 17, 2018 · 0 comments

Comments

@TonyBarbour
Copy link
Contributor

Hologram allocates a uniform buffer to store the 5000 objects that it is rendering, resulting in a need for a 1.28 MB buffer. In it's call to UpdateDescriptorSets, it specified VK_WHOLE_SIZE for the range, without regard for the driver's limit specified in maxUniformBufferRange, which on at least one driver is 64k. Hologram::CreateDescriptorSets() should be fixed to update the uniform buffer in maxUniformBufferRange sized chunks by using multiple descriptor writes per buffer, using VkDescriptorBufferInfo.offset and .range as necessary to update the entire uniform buffer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant