Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakdown lost some addressess? #326

Open
Jorvanus opened this issue Feb 16, 2024 · 13 comments
Open

Breakdown lost some addressess? #326

Jorvanus opened this issue Feb 16, 2024 · 13 comments
Labels
bug Something isn't working

Comments

@Jorvanus
Copy link

Surely, there aren't just addresses that aren't there anymore? This doesn't look quite right.

image

@LukePrior
Copy link
Owner

LukePrior commented Feb 19, 2024

Hmmmm that is really strange, I think something changed because on all the recent commits addresses are getting deleted.

I have paused the run but will need to investigate to find the root cause.

@LukePrior
Copy link
Owner

Not sure if @lyricnz has any idea but there haven't been any major changes on our end so looks like something might have changed on the NBN side?

@captbonus
Copy link

Could this be due to several of the garbled LocIDs being trimmed? I have noticed between the 13/1 and 11/2 locations that had Loactions without a LocID infront have disappeared from the map. have attached photos for reference

image

image

@Jorvanus
Copy link
Author

Could this be due to several of the garbled LocIDs being trimmed? I have noticed between the 13/1 and 11/2 locations that had Loactions without a LocID infront have disappeared from the map. have attached photos for reference

image

image

Yeah, and if you plug that address into NBN, it acknowledges the address, but says more work needs to be done for this site to be connected.

All the ones I had a look at, all looked like sensible removals to me, as they don't have any active NBN connections to them.

@LukePrior
Copy link
Owner

Looking through the records while a lot of the addresses getting removed are ones without a valid LocID, some do have valid IDs.

@LukePrior
Copy link
Owner

The script should be using the listed locID in the results file and just querying NBN for updated details.

NBN has updated their autocomplete API to be less generous with matching it seems but I'm not sure why we are seemingly redoing this search...

@LukePrior
Copy link
Owner

Ok this is interesting it's a 404 error: https://github.com/LukePrior/nbn-upgrade-map/actions/runs/7946125610/job/21693534967

@LukePrior
Copy link
Owner

I think it has to do with extended_get_nbn_loc_id

@LukePrior
Copy link
Owner

LukePrior commented Feb 27, 2024

I don't know if it's blocking us or something else because it works on reqbin, but not locally
image

https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k

curl -X GET https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k -H "Referer: https://www.nbnco.com.au/"

Can anyone confirm if this is same for them.

@Jorvanus
Copy link
Author

Not sure how you want me to test, but link doesn't work, and that line, gives me error in powershell.

That LOCID does work on the script I used to run myself.
irm -Headers @{'referer'='https://www.nbnco.com.au/'} https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k | fl

timestamp : 1709024991023
servingArea : @{csaId=CSA300000010073; techType=WIRELESS; serviceType=Fixed wireless; serviceStatus=available;
serviceCategory=brownfields; rfsMessage=Jul 2013; description=WCA-Willowmavin}
addressDetail : @{latitude=-37.30807800000001; longitude=144.8932779; reasonCode=FW_SA; serviceType=Fixed
wireless; serviceStatus=available; techType=WIRELESS; ee=False}
addressSplitDetails : @{address1=150 High Park Rd; locality=Forbes; state=VIC; postcode=3764}

@Jorvanus
Copy link
Author

image

@LukePrior
Copy link
Owner

LukePrior commented Feb 27, 2024

I've set it to rerun, seems the failing addresses have been fully removed from NBN so I guess not too much of an issue.

I think when the suburbs get updated again it will try to add them back with their new locID if available.

https://github.com/LukePrior/nbn-upgrade-map/actions/runs/8062401331/job/22022041834

@LukePrior LukePrior added the bug Something isn't working label Feb 27, 2024
@LukePrior
Copy link
Owner

Will revisit in a few weeks but hopefully it should stabilise, once it does can look into adjusting stats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants