Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LukesLazyLoader.load broken #5

Open
logidelic opened this issue Sep 26, 2016 · 1 comment · May be fixed by #7
Open

LukesLazyLoader.load broken #5

logidelic opened this issue Sep 26, 2016 · 1 comment · May be fixed by #7

Comments

@logidelic
Copy link

logidelic commented Sep 26, 2016

LukesLazyLoader.load is broken (at least in latest version of chrome). The reason is that, since LukesLazyLoader.load explicilty passes two arguments to the LukesLazyLoaderconstructor, the constructor only has access to those two arguments, (when it looks at the arguments variables), as a opposed to a variable number of arguments as you intended.

Thus when you write the following in the docs:

LukesLazyLoader.load('your', 'css', 'and', 'js', 'files').then(callback).then(anotherCallback);

Only 'your' and 'css' will be loaded. The following three arguments are ignored.

@LukasBombach
Copy link
Owner

Hy @logidelic thanks! I have so little time currently but I will try and fix it, thank you!

@aslafy-z aslafy-z linked a pull request Oct 9, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants