Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LuaCATS library with a dependent extension #127

Open
notpeter opened this issue Oct 19, 2023 · 1 comment
Open

Include LuaCATS library with a dependent extension #127

notpeter opened this issue Oct 19, 2023 · 1 comment

Comments

@notpeter
Copy link
Contributor

Hi,

I have a set of LuaCATS types for a proprietary SDK: https://github.com/notpeter/playdate-luacats/

I would like to create a simple VSCode extension which depends upon sumneko.lua and bundles those types. Is this possible?

If it is not currently possible, I believe vscode-lua could provide a public API for other extensions by adding additional functions to the object returned from the activate(context: vscode.ExtensionContext) function:

return {
async reportAPIDoc(params: unknown) {
await languageserver.reportAPIDoc(params);
}
};

See: VSCode extensions API Documentation.

This exported API could be something simple like library_add(path) so I can provide a path to a subdirectory in my extension bundle for my lua ---@meta files.

I would love to attempt this myself, but I'm still struggling setup a working extension development environment. See: #125.

Thanks again for creating a great extension.

@notpeter notpeter changed the title Possible to bundle LuaCATS library with extension Include LuaCATS library with a dependent extension Oct 19, 2023
@carsakiller
Copy link
Collaborator

The intention with addons is that the language server can support definitions like this so that you don't have to make your own VS Code extension and it can be used in other editors as well. You could configure your addon for "automatic" enabling using a config.json to make things a little easier.

You could also add this to LLS-Addons which can then be used by the addon manager in VS Code – however, reading their license makes me think that maybe they would not like that.

Currently, my concern is that managing addons and installing them is quickly turning into a full-blown package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants