fixed a few bugs related to error reporting. Removed async and made tests pending until I can come up with a clean way of re-implementing it. Current implementation of async did not play nice with output handlers

Author: DorianGray

bin/busted

@@ -47,8 +47,8 @@ cli:add_flag('--suppress-pending', 'suppress `pending` test output')
 cli:add_flag('--defer-print', 'defer print to when test suite is complete')
 
 -- Parse the cli arguments
-local cliArgs, error = cli:parse()
-if error then
+local cliArgs, hasError = cli:parse()
+if hasError then
   os.exit(1)
 end
 
@@ -181,14 +181,16 @@ testFileLoader(rootFile, pattern)
 local failures = 0
 local errors = 0
 
-busted.subscribe({ 'error' }, function()
+busted.subscribe({ 'error' }, function(...)
   errors = errors + 1
+  return nil, true
 end)
 
 busted.subscribe({ 'test', 'end' }, function(element, parent, status)
   if status == 'failure' then
     failures = failures + 1
   end
+  return nil, true
 end)
 
 busted.publish({ 'suite', 'start' })
@@ -199,5 +201,4 @@ local exit = 0
 if failures > 0 or errors > 0 then
   exit = 1
 end
-
 os.exit(exit)

busted/init.lua

@@ -98,17 +98,6 @@ return function(busted)
     busted.publish({ 'test', 'end' }, pending, busted.context.parent(pending), 'pending', trace)
   end
 
-  local async = function()
-    local parent = busted.context.get()
-    if not parent.env then parent.env = {} end
-
-    parent.env.done = require 'busted.done'.new(function()
-      busted.publish({ 'test', 'end' }, it, parent, 'success')
-      if finally then busted.safe('finally', finally, it) end
-      dexecAll('after_each', parent, true)
-    end)
-  end
-
   busted.register('file', file)
 
   busted.register('describe', describe)
@@ -117,8 +106,6 @@ return function(busted)
   busted.register('it', it)
   busted.register('pending', pending)
 
-  busted.context.get().env.async = async
-
   busted.register('setup')
   busted.register('teardown')
   busted.register('before_each')

spec/async_spec.lua

@@ -1,4 +1,4 @@
-describe('testing the done callback with tokens', function()
+pending('testing the done callback with tokens', function()
 
   it('Tests done call back ordered', function()
     async()
@@ -49,7 +49,7 @@ describe('testing the done callback with tokens', function()
   end)
 end)
 
-describe('testing done callbacks being provided for async tests', function()
+pending('testing done callbacks being provided for async tests', function()
   setup(function()
     async()
     assert.is_table(done)