Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLCModelSource uses fetch1 when restricting by a secondary key #1105

Open
CBroz1 opened this issue Sep 11, 2024 · 0 comments
Open

DLCModelSource uses fetch1 when restricting by a secondary key #1105

CBroz1 opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working position

Comments

@CBroz1
Copy link
Member

CBroz1 commented Sep 11, 2024

This portion of position_dlc_model

  1. Uses a FreeTable to fetch a dependency
  2. Presumes uniqueness of project_name that is not enforced by the DLCModelTraining table

table_query = dj.FreeTable(
dj.conn(), full_table_name=part_table.parents()[-1]
) & {"project_name": project_name}
project_path = table_query.fetch1("project_path")

These should be removed in favor if restricting by the primary key of the parent, used directly

@CBroz1 CBroz1 self-assigned this Sep 11, 2024
@CBroz1 CBroz1 added bug Something isn't working position labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working position
Projects
None yet
Development

No branches or pull requests

1 participant