You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The “Open Dexcom App” button does not work if using Dexcom One and One+, because the app URLs only point at the G6 and G7 apps, in the respective submodules:
One:
Unknown, possibly not existing (dexcomone:// does not work)
G7:
dexcomg7://
One+:
dexcomoneplus://
Suggestion:
Detect what app is used based on transmitter ID, and use the relevant url string. If the Dexcom One url remains unknown, hide the button for opening the app.
App URLs can easily be verified by entering the url in Safri on the phone.
The “Open Dexcom App” button does not work if using Dexcom One and One+, because the app URLs only point at the G6 and G7 apps, in the respective submodules:
G6:
https://github.com/LoopKit/CGMBLEKit/blob/4adef2662060f7d11d1abd8d099c3e022bf00cef/CGMBLEKit/TransmitterManager.swift#L486
G7:
https://github.com/LoopKit/G7SensorKit/blob/2be3eb29b0a18aa89f8b60281341e46e07d024e5/G7SensorKitUI/Views/G7SettingsView.swift#L129
App URLs overview:
G6:
dexcomg6://
One:
Unknown, possibly not existing (dexcomone:// does not work)
G7:
dexcomg7://
One+:
dexcomoneplus://
Suggestion:
Detect what app is used based on transmitter ID, and use the relevant url string. If the Dexcom One url remains unknown, hide the button for opening the app.
App URLs can easily be verified by entering the url in Safri on the phone.
Transmitter IDs for G7 vs One+:
https://github.com/LoopKit/G7SensorKit/blob/2be3eb29b0a18aa89f8b60281341e46e07d024e5/G7SensorKit/G7CGMManager/G7Sensor.swift#L217-L218
Probably useable patterns for discriminating between G6 and One as well, possibly from starting by 8 or 2 respectively?
Loop Version
The text was updated successfully, but these errors were encountered: