Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dexcom One and One+: The “Open Dexcom App” button does not work #2243

Open
bjornoleh opened this issue Oct 11, 2024 · 0 comments
Open

Dexcom One and One+: The “Open Dexcom App” button does not work #2243

bjornoleh opened this issue Oct 11, 2024 · 0 comments

Comments

@bjornoleh
Copy link
Contributor

The “Open Dexcom App” button does not work if using Dexcom One and One+, because the app URLs only point at the G6 and G7 apps, in the respective submodules:

G6:
https://github.com/LoopKit/CGMBLEKit/blob/4adef2662060f7d11d1abd8d099c3e022bf00cef/CGMBLEKit/TransmitterManager.swift#L486

G7:
https://github.com/LoopKit/G7SensorKit/blob/2be3eb29b0a18aa89f8b60281341e46e07d024e5/G7SensorKitUI/Views/G7SettingsView.swift#L129

App URLs overview:

G6:
dexcomg6://

One:
Unknown, possibly not existing (dexcomone:// does not work)

G7:
dexcomg7://

One+:
dexcomoneplus://

Suggestion:
Detect what app is used based on transmitter ID, and use the relevant url string. If the Dexcom One url remains unknown, hide the button for opening the app.

App URLs can easily be verified by entering the url in Safri on the phone.

Transmitter IDs for G7 vs One+:

https://github.com/LoopKit/G7SensorKit/blob/2be3eb29b0a18aa89f8b60281341e46e07d024e5/G7SensorKit/G7CGMManager/G7Sensor.swift#L217-L218

Probably useable patterns for discriminating between G6 and One as well, possibly from starting by 8 or 2 respectively?

Loop Version

  • LoopWorkspace dev ec86060d1004e77adb993937ca639b022e2214b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant