Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCL package not compiling #365

Closed
Tesla2k opened this issue Mar 11, 2021 · 5 comments
Closed

JCL package not compiling #365

Tesla2k opened this issue Mar 11, 2021 · 5 comments

Comments

@Tesla2k
Copy link

Tesla2k commented Mar 11, 2021

Hello,
I have installed Lazarus with fpcupdeluxe on Windows. The 32Bit Version. FPC and Lazarus both in the stable Version.
Afterwards I installed the JCL Module, but when I try to compile the Package in Lazarus I get the following errors:

JclStrings.pas(5393,10) Error: function header doesn't match the previous declaration "CompareNaturalStr(const AnsiString;const AnsiString):LongInt;"
JclStrings.pas(5398,10) Error: function header doesn't match the previous declaration "CompareNaturalText(const AnsiString;const AnsiString):LongInt;"

This is mentioned in this bug report
But the last entry is from 2013 and with the message, that there is a patch for this.

Can it be that fpcupdeluxe installs an old version or why is this issue still around?

@LongDirtyAnimAlf
Copy link
Owner

This is not a fpcupdeluxe issue, but a JCL issue.

The latest sources contain errors. These need to be resolved upstream.
Besides, JCL cannot be used out-of-the-box. It needs to be installed.

Have a look here.
https://github.com/LongDirtyAnimAlf/FPC-USB-HID/tree/master/jcl/jcl/source
https://github.com/LongDirtyAnimAlf/FPC-USB-HID/tree/master/jedi
https://github.com/LongDirtyAnimAlf/FPC-USB-HID/tree/master/jvcl/jvcl

Closing.

@LongDirtyAnimAlf
Copy link
Owner

Re-opening.
Will look into this issue again, due to the fact that, as you pointed out, old sources from a GitHub repo are used.

@LongDirtyAnimAlf
Copy link
Owner

I have looked into the latest jcl sources. These still contain many errors and are (at the moment) not compatible with FPC.
Again, as this is not related to fpcupdeluxe, I will close this issue.

@Tesla2k
Copy link
Author

Tesla2k commented Mar 24, 2021

As of the comment here JCL and JVCL are not supposed to support FPC and Lazarus.
Maybe you can add a short note in the description of the module, that it is not officially supported and may not work. So everybody is prewarned.

@LongDirtyAnimAlf
Copy link
Owner

The above was also the reasoning for not using the upstream JCL, but the (older) JCL that was guaranteed to build with FPC.
However, its not that hard to have a compatible upstream JCL. If time permits, will look into forking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants