From eeb5711f7cd74a0d77d1caaa67f45af1becf06c6 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 17 Oct 2022 12:51:14 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- src/ml4logs/data/utils.py | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/ml4logs/data/utils.py b/src/ml4logs/data/utils.py index 68b4b83..aa12311 100644 --- a/src/ml4logs/data/utils.py +++ b/src/ml4logs/data/utils.py @@ -42,7 +42,29 @@ def extract(args): with tarfile.open(in_path, 'r:gz') as tar: members = tar.getmembers() logger.info('Extracting %d files', len(members)) - tar.extractall(out_dir, members=members) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, out_dir, members=members) def head(args):