Skip to content
This repository has been archived by the owner on Nov 9, 2024. It is now read-only.

Update image tags to represent versions of each application #104

Open
dskaggs opened this issue Aug 27, 2020 · 8 comments
Open

Update image tags to represent versions of each application #104

dskaggs opened this issue Aug 27, 2020 · 8 comments
Assignees
Labels
status/in-progress type/maintenance General repo maintenance that doesn't fit into other labels

Comments

@dskaggs
Copy link
Contributor

dskaggs commented Aug 27, 2020

Once images have been published to a DockerHub organization, update the tags of each to be a version number rather than the name of the container.

Blocked by #103

@adam-stanek
Copy link
Contributor

It is not only about splitting the images / using version tags properly, but it would be also good to split the build as well. I have been tinkering with the lodestone-processor repo and it sucks that you cannot easily build image out of it. Instead the docker image is built in the lodestone repo but only using artifacts already published to the repository (https://github.com/LodestoneHQ/lodestone/blob/master/processor/Dockerfile#L9). This effectively closes your project to any contributors because you have no easy way of building image out of fork / merge request.

Instead of this each repo should be responsible for building itself. There is no real benefit of this added complexity.

@dskaggs
Copy link
Contributor Author

dskaggs commented Jan 5, 2021

Totally agreed. Eventually I would like each of these repos to be completely decoupled from each other.

@dskaggs dskaggs self-assigned this Feb 3, 2021
@dskaggs
Copy link
Contributor Author

dskaggs commented Feb 3, 2021

@adam-stanek Would you mind creating an issue for the changes you'd like to see in the build processes for each component?

@dskaggs dskaggs added status/in-progress type/maintenance General repo maintenance that doesn't fit into other labels labels Feb 3, 2021
@adam-stanek
Copy link
Contributor

Added #111 and #112

@dskaggs
Copy link
Contributor Author

dskaggs commented Feb 3, 2021

Added #111 and #112

Thank you! Looking over the PR now. I'll have some questions to help my understanding of how the changes fit into the overall docker-compose but I'll put those over on those tickets.

@adam-stanek
Copy link
Contributor

I looked at the built images on docker hub and noticed you are only building latest tags. Do you think it would be possible to also tag individual releases? I think it is crucial for production use when you want to prevent potential breaking changes in cloud deployments. The deployment should always be repeatable and transferable between nodes (you need stable images).

@dskaggs
Copy link
Contributor Author

dskaggs commented Feb 4, 2021

Do you think it would be possible to also tag individual releases

Yes definitely. They're all set up to build a version tag any time we actually release a version in GitHub. I just haven't release anything new yet as I was waiting for things to get more stable. You can see there's a latest and a v0.2.1 tag for the main lodestone repo (https://hub.docker.com/r/lodestonehq/lodestone/tags?page=1&ordering=last_updated). The other repos will do that as well when a new release is tagged.

@adam-stanek
Copy link
Contributor

Good to know 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/in-progress type/maintenance General repo maintenance that doesn't fit into other labels
Projects
None yet
Development

No branches or pull requests

2 participants