-
Notifications
You must be signed in to change notification settings - Fork 29
Update image tags to represent versions of each application #104
Comments
It is not only about splitting the images / using version tags properly, but it would be also good to split the build as well. I have been tinkering with the lodestone-processor repo and it sucks that you cannot easily build image out of it. Instead the docker image is built in the lodestone repo but only using artifacts already published to the repository (https://github.com/LodestoneHQ/lodestone/blob/master/processor/Dockerfile#L9). This effectively closes your project to any contributors because you have no easy way of building image out of fork / merge request. Instead of this each repo should be responsible for building itself. There is no real benefit of this added complexity. |
Totally agreed. Eventually I would like each of these repos to be completely decoupled from each other. |
@adam-stanek Would you mind creating an issue for the changes you'd like to see in the build processes for each component? |
I looked at the built images on docker hub and noticed you are only building |
Yes definitely. They're all set up to build a version tag any time we actually release a version in GitHub. I just haven't release anything new yet as I was waiting for things to get more stable. You can see there's a |
Good to know 👍 |
Once images have been published to a DockerHub organization, update the tags of each to be a version number rather than the name of the container.
Blocked by #103
The text was updated successfully, but these errors were encountered: