Fix panic when formatting TimeStamp::MIN
#838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to print the minus sign of times, we detect the need for the minus sign, print it and then print the absolute value of the time. However, integers have a minimum value that is one less than the absolute value of the maximum value. This means that the minimum value of a signed integer cannot be negated. This caused a panic when formatting `TimeStamp::MIN` when overflow checks are enabled, such as when compiling with the debug profile. There was also a big lack of tests for the formatting of times. Tests are now included for all the important cases.
CryZe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to print the minus sign of times, we detect the need for the minus sign, print it and then print the absolute value of the time. However, integers have a minimum value of which the absolute value is larger than the maximum value of the integer. So for example
i8has a minimum value of-128and a maximum value of127. The absolute value therefore can't be represented. This caused a panic when formattingTimeStamp::MINwhen overflow checks are enabled, such as when compiling with the debug profile.There was also a big lack of tests for the formatting of times. Tests are now included for all the important cases.