Add stderr Support for Auto Splitters
#835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto splitters can now print to `stderr`, which is the same as printing via `print_message`, except that like a usual terminal it is line buffered and either flushed on new lines or manually. This then ends up in the same `log_auto_splitter` call that `print_message` ends up in. The logging now also differentiates between messages that come from the auto splitter and messages that come from the runtime. Additionally this bumps `wasmtime` to version 24.
CryZe
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto splitters can now print to
stderr, which is the same as printing viaprint_message, except that like a usual terminal it is line buffered and either flushed on new lines or manually. This then ends up in the samelog_auto_splittercall thatprint_messageends up in. The logging now also differentiates between messages that come from the auto splitter and messages that come from the runtime. Additionally this bumpswasmtimeto version 24.