Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AVIF images #773

Open
CryZe opened this issue Feb 19, 2024 · 2 comments
Open

Support AVIF images #773

CryZe opened this issue Feb 19, 2024 · 2 comments
Labels
blocked Progress is blocked and can't progress. enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. needs further discussion It is unclear how to progress without making further decisions. rendering The issue or pull request is affecting the rendering.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Feb 19, 2024

AVIF is now supported by all browsers and is generally the better format. We should look into supporting it and maybe even making it our default format. We'd need to have some compatibility support for the original LiveSplit though.

@CryZe CryZe added enhancement An improvement for livesplit-core. needs further discussion It is unclear how to progress without making further decisions. rendering The issue or pull request is affecting the rendering. feature A new user visible feature for livesplit-core. labels Feb 19, 2024
@CryZe
Copy link
Collaborator Author

CryZe commented Feb 24, 2024

Turns out that while there's pure Rust AVIF encoding, there's no AVIF decoding in pure Rust. That basically blocks the entire issue for now.

@CryZe CryZe added the blocked Progress is blocked and can't progress. label Feb 24, 2024
@CryZe
Copy link
Collaborator Author

CryZe commented Jun 14, 2024

I checked this out again, because it seems like rav1d is making decent progress. I was able to encode AVIF in the web version, where decoding isn't necessary anyway, because the browser will decode it for us. While there's definitely significant size wins, the encoding speed is really bad. Turns out that we can just bump the quality of the PNG compression that we do. While it doesn't get us to the compression level of AVIF, it still stays fast enough that I ended up merging that: #817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress is blocked and can't progress. enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. needs further discussion It is unclear how to progress without making further decisions. rendering The issue or pull request is affecting the rendering.
Projects
None yet
Development

No branches or pull requests

1 participant