Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to detect key release in livesplit-hotkey #633

Open
Roger opened this issue Feb 12, 2023 · 1 comment
Open

Add a way to detect key release in livesplit-hotkey #633

Roger opened this issue Feb 12, 2023 · 1 comment
Labels
feature A new user visible feature for livesplit-core. hotkey This is about the hotkey implementation. needs further discussion It is unclear how to progress without making further decisions.

Comments

@Roger
Copy link

Roger commented Feb 12, 2023

Currently is only possible to detect keys pressed, but not the release event.

Had a look at the linux implementations and should be simple (didn't check mac/win/wasm), but I don't think that there's a way to make this backwards compatible other than creating another register/unregister methods.

Would you consider something like this? what would be a good api? new methods? an argument in the callback with some enum with KeyDown/KeyUp? another optional callback for the release?

@CryZe CryZe added needs further discussion It is unclear how to progress without making further decisions. feature A new user visible feature for livesplit-core. hotkey This is about the hotkey implementation. labels Feb 19, 2024
@CryZe
Copy link
Collaborator

CryZe commented Feb 19, 2024

Mmh, I'm not sure this makes sense for our use case, cause it's not a generic keyboard API and instead specifically a hotkey listener where you want to know when the hotkey is pressed, especially in our case where the timing is really important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new user visible feature for livesplit-core. hotkey This is about the hotkey implementation. needs further discussion It is unclear how to progress without making further decisions.
Projects
None yet
Development

No branches or pull requests

2 participants