Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Reference to USD should be replaced with BTC or removed completely #44

Open
qtipwax opened this issue May 12, 2016 · 5 comments
Open

Reference to USD should be replaced with BTC or removed completely #44

qtipwax opened this issue May 12, 2016 · 5 comments

Comments

@qtipwax
Copy link

qtipwax commented May 12, 2016

I would like the reference to USD removed. It is biased towards one country and cypto should try to move away from fiat references when possible. Possible solutions.

  1. Replaced with BTC value would be more appropriate in my opinion.
  2. If not all languages that Lisk supports should have their currency listed.
  3. References to other fiat or crypto removed completely.
@qtipwax
Copy link
Author

qtipwax commented May 12, 2016

usd

@densmirnov
Copy link
Contributor

I disagree. First of all, the ability to know the value of your assets without accessing the exchange is very handy. Second, USD is like universal standard for crypto accepted by everyone no matter what country are you from. Just as Bitcoin. Rather, I would add an option to select which currency you prefer to see. But in any case, it wouldn't remove it.

@karmacoma karmacoma self-assigned this May 14, 2016
@mrv777
Copy link
Contributor

mrv777 commented May 18, 2016

Looks like you could change:

$scope.convertToUSD = function (lisk) {
        return (lisk / 100000000) * $scope.lisk_usd;
    };

to something like this to get the new value:

$scope.convertToUSD = function (lisk) {
        if (someSetting=='btc')
                return (lisk / 100000000) * $scope.lisk_btc;
        else
                return (lisk / 100000000) * $scope.lisk_usd;
    };

Would also need to update these with an if statement to make it obvious it is BTC and not USD now:
partials/modals/userInfo.html
partials/modals/transactionInfo.html
partials/modals/blockInfo.html

@qtipwax
Copy link
Author

qtipwax commented May 18, 2016

My issue with USD is that I need to convert it again into the "local" currency whether Chinese Yuan, Korean Won, Euro, Krone, Rupee, etc. If using BTC there is only one conversion and I know the value.

@karmacoma karmacoma removed their assignment Jun 14, 2016
@fix
Copy link

fix commented Aug 30, 2016

Closing it as won't fix, what do you think @karmacoma ?

@karmacoma karmacoma changed the title Reference to USD should be replaced with BTC or removed completely. Reference to USD should be replaced with BTC or removed completely Apr 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants