Skip to content

Ids for M3 Elements #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enikao opened this issue Jan 13, 2023 · 8 comments
Closed

Ids for M3 Elements #53

enikao opened this issue Jan 13, 2023 · 8 comments

Comments

@enikao
Copy link
Contributor

enikao commented Jan 13, 2023

Which ids are we using for M3 elements?

Option A: Use fully qualified name the element

Example: LIonCore.Concept

  • Makes M2 serializations human-readable, as we know whether an entry is a Concept, Containment, etc.
  • M3 ids never change (part of specification)
  • Need to be the same in all implementations

Option B: Use arbitarily chosen ids

Examples: 23948723 or ALkdlkh-sdfkl_32

  • In Repo API: Node IDs #31, we said that ids should not carry any meaning (i.e. should not be interpretable).
    We would violate our own guideline.

-> Decision: Option A (use FQNs)

@dslmeinte
Copy link
Contributor

Experimentation in the TypeScript-implementation going on in PR #

@dslmeinte
Copy link
Contributor

So, FQNs would be LIonCore.M3.Metamodel, LIonCore.M3.Concept, etc., right? (LIonCore.M3. is always the prefix.)

@enikao
Copy link
Contributor Author

enikao commented Jan 13, 2023

So, FQNs would be LIonCore.M3.Metamodel, LIonCore.M3.Concept, etc., right? (LIonCore.M3. is always the prefix.)

These are not valid ids (because of the dot).

@dslmeinte
Copy link
Contributor

So, FQNs would be LIonCore.M3.Metamodel, LIonCore.M3.Concept, etc., right? (LIonCore.M3. is always the prefix.)

These are not valid ids (because of the dot).

Where did we document the criteria of valid IDs again?

@enikao
Copy link
Contributor Author

enikao commented Jan 13, 2023

Where did we document the criteria of valid IDs again?

#31

@dslmeinte
Copy link
Contributor

OK, I fixed the invalid IDs in LionWeb-io/lionweb-typescript#25

@enikao
Copy link
Contributor Author

enikao commented Jan 16, 2023

OK, I fixed the invalid IDs in LIonWeb-org/lioncore-typescript#25

For the record: This PR implies the FQNs would be like LIonCore_M3_Metamodel_qualifiedName

@enikao
Copy link
Contributor Author

enikao commented Feb 12, 2023

@enikao enikao closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants