Skip to content

Add id field to MetamodelElement and Metamodel #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enikao opened this issue Nov 28, 2022 · 3 comments · Fixed by #47
Closed

Add id field to MetamodelElement and Metamodel #46

enikao opened this issue Nov 28, 2022 · 3 comments · Fixed by #47
Labels

Comments

@enikao
Copy link
Contributor

enikao commented Nov 28, 2022

We want to be stable against renaming of Metamodels, Concepts, Features etc.
Thus references to them should use an id, not their name.

This is not an implementation detail, as these ids would be used in the protocol.

Relates to #31.

@ftomassetti
Copy link
Contributor

From my point of view would be important to support both the models obtained from projectional editing and from parsing. In the first case, IDs could be generated, while in the second case should be stable, maybe based on the position of the node on the tree, maybe on the name of entity (e.g., the name of the class, the name of the function, etc.).

Should ID be strings? Should ID be just an interface with possibly multiple implementation? I think this is a topic with a lot of implications and we should discuss it during one of the next meetings

@dslmeinte
Copy link
Contributor

I think they should be strings, because they ought to be serializable without fuss. Anything more complicated, and chances are that other concerns (such as namespace identification and such) are leaking into their purpose.

@enikao
Copy link
Contributor Author

enikao commented Dec 1, 2022

Shall we have this discussion at #31? I think that's more suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants