Skip to content

Support commentable nodes #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enikao opened this issue Oct 14, 2022 · 4 comments
Open

Support commentable nodes #15

enikao opened this issue Oct 14, 2022 · 4 comments
Labels
M3 postponed Postponed for later discussion

Comments

@enikao
Copy link
Contributor

enikao commented Oct 14, 2022

Does LionCore support commentable nodes out-of-the-box?
Do we need support on M3 level?

Assumptions:

  • In any case will not influence M3 heavily

Decision: Postponed

@slisson
Copy link

slisson commented Oct 14, 2022

MPS has separate operations for accessing the children with (.childrenAndAttributes<...>) and without (.children<...>) the commented ones. It's easy to pick the wrong one and forget to include the commented ones. Maybe we can make our API less error prone by adding support for them from the beginning and not add it later as it was done in MPS.

@markusvoelter
Copy link
Contributor

Good point: while the storage and representation of commented nodes is not relevant to M3, the API is. In that sense this is something we should consider when defining M3 APIs.

@ftomassetti ftomassetti added the M3 label Nov 4, 2022
@enikao enikao added the postponed Postponed for later discussion label Nov 25, 2022
@enikao
Copy link
Contributor Author

enikao commented Nov 25, 2022

MPS can only use sNodeAttributes to store commented nodes as it internally stores all children of a node in one list, and thus can move a commented child from its original link to the sNodeAttribute link and retain the child's position (according to Sergej).

Depending on #37, this solution might not work for us.

@enikao
Copy link
Contributor Author

enikao commented Nov 25, 2022

Briefly discussed on 2022-11-25, but couldn't come up with a good idea => postponed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M3 postponed Postponed for later discussion
Projects
None yet
Development

No branches or pull requests

4 participants