-
Notifications
You must be signed in to change notification settings - Fork 4
Serialization of primitive properties #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
question
Further information is requested
Comments
Let's discuss on Wednesday. |
Result: yes, all primitive values should be serialized as strings (including JSON). |
fixed by commit 45c8912 |
Is there anything from your discussion to add to LionWeb-io/specification#34, especially regarding rationale? |
It seems not. Maybe the biggest thing is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on serialization I noticed that some property values (in particular boolean properties) are serialized as JSON booleans (e.g.,
true
orfalse
). My understanding is that all property values should be serialized as strings (e.g.,"true"
or"false"
), so when copying https://github.com/LIonWeb-org/lioncore-typescript/blob/main/models/library.json into the lioncore-java repository I have changed those values.I am opening the issue to discuss how to converge on this point.
The text was updated successfully, but these errors were encountered: