Skip to content

Question: are metamodels used in serialization implicit? #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ftomassetti opened this issue Jan 21, 2023 · 7 comments
Closed

Question: are metamodels used in serialization implicit? #32

ftomassetti opened this issue Jan 21, 2023 · 7 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@ftomassetti
Copy link
Contributor

If I look at this file it is specifying nodes with types such as LIonCore_M3_Metamodel or LIonCore_M3_PrimitiveType. In general, should we declare with metamodels are we using? Is LionCore itself a special implicit metamodel and others should be declared?
I think it would be useful to know which metamodels are used by reading an header, so I could either reject the model, if I do not know how to handle that metamodel, or do initialization steps to load such metamodel

@dslmeinte
Copy link
Contributor

No, this is going to be explicit, as in PR #29 - see e.g. this file location. (Feel free to review that PR.)

@enikao
Copy link
Contributor

enikao commented Jan 23, 2023

Relates to LionWeb-io/specification#50

@dslmeinte dslmeinte added the question Further information is requested label Jan 24, 2023
@dslmeinte dslmeinte added the bug Something isn't working label Feb 7, 2023
@dslmeinte
Copy link
Contributor

To align with LionWeb-io/specification#9 (comment) : built-in primitive types are imported implicitly, without needing to depend explicitly through Metamodel.dependsOn.

@dslmeinte
Copy link
Contributor

fixed through commit 65d86a6

@enikao
Copy link
Contributor

enikao commented Feb 9, 2023

Did you discuss whether we want to list used metamodels explicitly in serialization? E.g. in a serialized M1 model, do we explicitly list all M2 metamodels referred to by concept, properties, children, references, etc?

@dslmeinte
Copy link
Contributor

No, we didn't discuss it. I think we interpreted dependsOn similar to a model import. I think a dependsOn that points to specific metamodels (of languages) should maybe go in a separate feature, such as conformsTo?

@enikao
Copy link
Contributor

enikao commented Feb 9, 2023

Good idea: LionWeb-io/specification#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants