Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matcher struct to solver matcher package #504

Open
bgins opened this issue Jan 30, 2025 · 0 comments
Open

Add matcher struct to solver matcher package #504

bgins opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels

Comments

@bgins
Copy link
Contributor

bgins commented Jan 30, 2025

General Description

Refactor the solver matcher around a matcher struct to make it easier to break matching functionality into separate functions.

Which system(s) or functionality does this affect

This functionality only affects the solver.

Describe the changes, and how this affects/ interacts with each system.

Our solver matcher currently exists as a single GetMatchingDeals function with a couple of helper functions. For each helper function, we need to pass dependencies like the store, tracer, and logger.

We could improve this situation by adding a matcher struct and implement helper functions off it as methods.

@bgins bgins added the solver label Jan 30, 2025
@bgins bgins self-assigned this Jan 30, 2025
@bgins bgins mentioned this issue Jan 30, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant