Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Create a conda-forge package for lightning-flash #659

Closed
weiji14 opened this issue Aug 16, 2021 · 4 comments
Closed

Create a conda-forge package for lightning-flash #659

weiji14 opened this issue Aug 16, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on

Comments

@weiji14
Copy link

weiji14 commented Aug 16, 2021

🚀 Feature

Motivation

Hi there, I'd like to make it easier for users to install lightning-flash using the conda package manager! I noticed that only pip install is possible for lightning-flash v0.4.0 according to https://lightning-flash.readthedocs.io/en/0.4.0/installation.html, but would love to see a conda install option too!

Pitch

Make conda install -c conda-forge lighning-flash work.

Alternatives

Keep using pip install only 🙂

Additional context

I'll be following the instructions at https://conda-forge.org/#add_recipe to add a new conda-forge recipe to lightning-flash, and will submit a Pull Request to https://github.com/conda-forge/staged-recipes. Before I do so though, I'd like to ask:

  1. Who is interested to be a recipe maintainer for pytorch-lightning on conda-forge? (usually just involves pushing a button when a new version is released, as most things are automated)
  2. Are there any complicated dependency issues I should be aware of? I'll just start with the base lightning-flash package for now, and maybe do lightning-flash[all] later.
@weiji14 weiji14 added enhancement New feature or request help wanted Extra attention is needed labels Aug 16, 2021
@LoopGlitch26
Copy link

I'm interested to contribute and work on this issue @weiji14 @aniketmaurya

@weiji14
Copy link
Author

weiji14 commented Aug 24, 2021

Hi @LoopGlitch26, thanks for your interest! I've opened up a PR already at conda-forge/staged-recipes#15917 to add lightning-flash to conda-forge. Once that is merged though (edit: done!), I suppose we'll need to update the installation documentation, would you like to open a PR to update installation.md with the conda install option?

@weiji14
Copy link
Author

weiji14 commented Aug 24, 2021

Ok, lightning-flash is now available at https://anaconda.org/conda-forge/lightning-flash! However, this is just the base installation (i.e. what you get from pip install lightning-flash). There are a few more dependencies that need to be on conda-forge in order to run image/audio tasks. I'll focus on lightning-flash[image] since I'm mostly interested in computer vision 😎

Dependency list from https://github.com/PyTorchLightning/lightning-flash/blob/0.4.0/requirements/datatype_image.txt, a ☑️ means available on conda-forge

There are more dependencies on PytorchLightning's master branch, but let's take it one step at a time 😁

https://github.com/PyTorchLightning/lightning-flash/blob/15bc77891856e06a111f8d410832a376d96d07b7/requirements/datatype_image.txt#L1-L10

Alternatively, the requirements could be relaxed somewhat (i.e. made optional) by modifying https://github.com/PyTorchLightning/lightning-flash/blob/15bc77891856e06a111f8d410832a376d96d07b7/flash/core/utilities/imports.py#L136-L147 otherwise people will get hit with an error like ModuleNotFoundError: Required dependencies not available. Please run: pip install 'lightning-flash[image]'

@stale
Copy link

stale bot commented Oct 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Oct 24, 2021
@stale stale bot closed this as completed Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants