Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make autocast a Transform #1122

Open
t-vi opened this issue Sep 7, 2024 · 1 comment · May be fixed by #1516
Open

Make autocast a Transform #1122

t-vi opened this issue Sep 7, 2024 · 1 comment · May be fixed by #1516
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@t-vi
Copy link
Collaborator

t-vi commented Sep 7, 2024

Currently autocast (transforms/autocast.py) is carried over from the old-style transforms on callable and invoked like

jit(autocast(fn))

it would be good to make this a AutocastTransform to be invoked as

jit(fn, transforms=[Autocast()])

for better composability.

This should be vaguely doable with the transforms e.g. as explained in Thunder Sessions Episode 7 plus the bsym mapping provided by the existing mechanism, so it might be a good first or second issue.

@t-vi t-vi added enhancement New feature or request good first issue Good for newcomers labels Sep 7, 2024
@rittik9
Copy link

rittik9 commented Nov 30, 2024

@t-vi I am interested in working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants