Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Post Changesets to PRs #42

Open
pbrisbin opened this issue Jan 6, 2022 · 0 comments
Open

[Feature] Post Changesets to PRs #42

pbrisbin opened this issue Jan 6, 2022 · 0 comments

Comments

@pbrisbin
Copy link
Contributor

pbrisbin commented Jan 6, 2022

When someone opens a PR in the GitOps repo managed by CG, CG could run through every deploy it would do but with --no-execute-changeset and then post the JSON output of describe-changeset calls back to the originating PR. This would make the PRs incredibly reviewable, as you can see exactly the infra changes that would occur if merged.

I think this would require re-architecting the S3 side of things somehow. IIUC, there is presently a single bucket with a single state that triggers a deploy when changed. We would somehow need to synchronize the branch's version of things in a way that accurately triggers on what differs, but without actually persisting. If there's a less disruptively way to add this feature, do let me know.

This would also not work if you push a PR that has dependent changes across stacks -- though I don't think that's particularly well-supported even when actually executing the deploys today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant