Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has_played_20_games should be renamed #549

Open
glbert-does opened this issue Jan 5, 2025 · 0 comments
Open

has_played_20_games should be renamed #549

glbert-does opened this issue Jan 5, 2025 · 0 comments
Labels
good first issue P3 - low Minor improvement to league experience (small ui glitch, spelling error, etc.)

Comments

@glbert-does
Copy link
Member

has_played_20_games = models.BooleanField()

has_played_20_games is a name that has been incorrect for 7 or 8 years – nowadays it should be has_established_rating or something similar.
this is a very small thing, but i still think it should be renamed. it's confusing if you're not familiar with how rating deviation worked on lichess historically and/or how the league rules changed to reflect this. mostly adding this issue so we don't forget about it.

@glbert-does glbert-does added P3 - low Minor improvement to league experience (small ui glitch, spelling error, etc.) good first issue labels Jan 5, 2025
@glbert-does glbert-does changed the title has_played_20_games has_played_20_games should be renamed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue P3 - low Minor improvement to league experience (small ui glitch, spelling error, etc.)
Projects
None yet
Development

No branches or pull requests

1 participant