Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of ESC key behavior in "The Command Line" is wrong #101

Open
lordofbikes opened this issue Aug 13, 2021 · 2 comments
Open

Description of ESC key behavior in "The Command Line" is wrong #101

lordofbikes opened this issue Aug 13, 2021 · 2 comments

Comments

@lordofbikes
Copy link
Member

I got notice of this issue by LibreCAD issue LibreCAD/LibreCAD#1373
In the manual the old 2.1.3 behavior is described.
For 2.2.0 the ESC behavior changed, all operations are fully canceled on first ESC press.
The behavior of right click was kept and is still like the described ESC behavior.
Right click goes back one step in chained actions like trimming or 2-point line drawing. ESC cancel these on first press.
Maybe this has to be described better on some other place, e.g. at Using a Mouse and Using the Keyboard in Fundamentals.

Source reference: https://github.com/LibreCAD/docs/blob/master/guides/cmdline.rst#command-line-functions

Maybe we should wait for a conclusion in the mentioned LibreCAD issue, if we keep current behavior or switch back to 2.1.3 style.
Anyhow, it seems that the right click behavior in active operations is not described at all yet.

@lordofbikes
Copy link
Member Author

Commenting on LibreCAD/LibreCAD#1373 I found out that it depends, if ESC is pressed in active command line or not.
When the command line has focus, e.g. when entering coordinates, ESC behaves like described.
It cancel the current action, not the whole operation. Sadly this looses focus and only CTRL-M can put focus back to command line.
When command line is not active, e.g. during trimming with mouse, ESC cancel operation on first hit.

@lordofbikes lordofbikes changed the title Description of ESC key beavior in "The Command Line" is wrong Description of ESC key behavior in "The Command Line" is wrong Aug 13, 2021
@ttk
Copy link

ttk commented Dec 10, 2024

I'm using LibreCAD v2.2.0 and I prefer to use the command line over the mouse input. Unfortunately, the current behavior of the ESC key doesn't work they way I expect. I haven't used v2.1.3, but from the sounds of it, it's probably more inline with the way I think it should work.

In any case, this is how I think it should work:

  1. Pressing ESC on the command line should clear any existing text in the command line. Focus should remain on the command line.
  2. If command line is empty, then pressing ESC should cancel the current action and goto the previous action. Focus should remain on the command line.
  3. If the current action was the first one, then pressing ESC should cancel the operation. Focus should remain on the command line.
  4. If no operation is in progress, then pressing ESC should remove focus from the command line.

Currently, the command line loses focus when I cancel the current action or the operation using ESC. This sucks because I want to continue using the command line and I have to use CTRL-M constantly to bring the focus back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants