Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Nodes #255

Open
flywire opened this issue Jan 20, 2020 · 10 comments
Open

Edit Nodes #255

flywire opened this issue Jan 20, 2020 · 10 comments

Comments

@flywire
Copy link
Contributor

flywire commented Jan 20, 2020

Edit (add, delete, move) nodes would be useful.

@rupakbajgain
Copy link
Contributor

Do you mean points?

@flywire
Copy link
Contributor Author

flywire commented Jun 27, 2020

Yes

@rupakbajgain
Copy link
Contributor

Ok, i will try that.

@flywire
Copy link
Contributor Author

flywire commented Jun 29, 2020

Please confirm #312 functionality.

The intent of this issue is say you have a square:

  • Deleting the node at the top right corner of the square would leave the remaining nodes to form a triangle.
  • Selecting the top line and dragging a new node into it would make it five-sided, like a house with a roof. Moving to the left or right of the line would allow more points to be added.

@rupakbajgain
Copy link
Contributor

Please confirm #312 functionality.

The intent of this issue is say you have a square:

* Deleting the node at the top right corner of the square would leave the remaining nodes to form a triangle.

* Selecting the top line and dragging a new node into it would make it five-sided, like a house with a roof. Moving to the left or right of the line would allow more points to be added.

Sorry i thought of another thing, may be this can be done in polyline only. I will think about it and try it when i find a way,

@flywire
Copy link
Contributor Author

flywire commented Jul 1, 2020

If a square, triangle and circle are polylines then yes. Maybe a point and a line are polylines with zero and one segments respectively?

@rupakbajgain
Copy link
Contributor

Please confirm #312 functionality.

The intent of this issue is say you have a square:

* Deleting the node at the top right corner of the square would leave the remaining nodes to form a triangle.

* Selecting the top line and dragging a new node into it would make it five-sided, like a house with a roof. Moving to the left or right of the line would allow more points to be added.

@flywire i am thinking of doing this my using dragpoints which are already there, how to diffrentiate between the dragging and (adding or removing node) maybe mouse button or keyboard shortcut, like del key press removes last clicked node, enter creates new node there, or diffrentiate left and right mouse click actions.

-> Or maybe it should be done as seperate operation. click add node and click polygon....

@rupakbajgain
Copy link
Contributor

If a square, triangle and circle are polylines then yes. Maybe a point and a line are polylines with zero and one segments respectively?

Line, Square, and Triangle (arc maybe)can be represented by polyline, but not point and circle.
@feragon how should we do it.

@flywire
Copy link
Contributor Author

flywire commented Jul 1, 2020

Dragpoints is interesting. Del deletes node, ins inserts node on line at the cursor location and the user can drag it as required. Maybe right mouse click brings up a context-sensitive menu.

To be clear, if using dragpoint:

  • delete operation: select node, (no drag) and delete
  • insert operation: select line, insert node, drag
  • add operation: select node at end of polyline, add node to end, drag

What is issue with point as zero segment polyline? It would be the same as points in the first paragraph above.

Circle - new node would make icecream cone shaped then the user could shape straight line(s) as required. Probably not, it would just change circle radius, circle would probably need to be split into [two?] arcs first.

@rupakbajgain
Copy link
Contributor

@flywire ,i think insert can be done as i have in video in zulip chat,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants